fix: handle JSON contents of create_new_file #8973

mcowger · 2025-12-02T20:16:36Z

Handle case where JSON content was parsed into an object by the tool call parser. If the arguments to the tool call are valid JSON (e.g. the model attempts to create a .json file) the earlier call to JSON.parse() will have deeply parsed the returned contents. If that has happened, convert back to string.

Fixes: #8972

Description

[ What changed? Feel free to be brief. ]

AI Code Review

Team members only: AI review runs automatically when PR is opened or marked ready for review
Team members can also trigger a review by commenting @continue-review

Checklist

I've read the contributing guide
The relevant docs, if any, have been updated or created
The relevant tests, if any, have been updated or created

Screen recording or screenshot

NA

Tests

Added 6 tests to core/tools/parseArgs.vitest.ts for new check.

Summary by cubic

Fixes failures when create_new_file receives JSON content parsed into an object by ensuring contents is always a string. Prevents crashes when creating .json files. Fixes #8972.

Bug Fixes
- In getStringArg, JSON.stringify object/array values to safely handle parsed JSON.
- Throw a clear error for non-string values after conversion.
- Added tests covering contents object/array handling and edge cases.

^{Written for commit e04c21f. Summary will update automatically on new commits.}

Handle case where JSON content was parsed into an object by the tool call parser. If the arguments to the tool call are valid JSON (e.g. the model attempts to create a .json file) the earlier call to JSON.parse() will have deeply parsed the returned contents. If that has happened, convert back to string. Fixes: continuedev#8972

continue · 2025-12-02T20:16:39Z

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

continue-development-app · 2025-12-02T20:16:40Z

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

continue-development-app · 2025-12-02T20:16:40Z

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

github-actions · 2025-12-02T20:16:47Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

RomneyDa

@mcowger could we add this special handling in createFileImpl instead of here?

OR, I think you could just remove special handling for contents and always make sure it's a string within getStringArg!

continue · 2025-12-02T20:18:06Z

Reviewed the PR changes. This is an internal bug fix in the tool argument parser that handles JSON content correctly when creating JSON files. The changes don't require documentation updates since:

This fixes internal parsing logic, not user-facing behavior
The existing documentation correctly describes the create_new_file tool functionality
The fix is transparent to users - it restores expected behavior rather than changing the tool's API or capabilities

The fix ensures that when models create .json files with JSON content, the parser correctly handles the case where the content gets parsed into an object and converts it back to a string.

mcowger · 2025-12-02T20:30:05Z

I have read the CLA Document and I hereby sign the CLA

mcowger · 2025-12-02T20:31:24Z

@mcowger could we add this special handling in createFileImpl instead of here?

OR, I think you could just remove special handling for contents and always make sure it's a string within getStringArg!

Good call. Removed the special case handling.

cubic-dev-ai

No issues found across 2 files

cubic-dev-ai

No issues found across 2 files

RomneyDa

@mcowger this looks good to me. I haven't been able to replicate the failing case locally - it seems like claude and openai models mostly escape JSON strings correctly. Could you share which model you find this error often happens with?

EDIT I see M2 in the issue but wasn't sure which model that was. Model + provider combo would be helpful

mcowger · 2025-12-02T22:05:24Z

I can replicate on Synthetic.new. It doesn't happen for me on OpenRouter either.

Happy to provide a key privately for you to test so you dont have to give them money.

RomneyDa · 2025-12-02T22:59:25Z

@mcowger which model are you working with?
EDIT this was a silly question, I see M2 on openrouter now
https://openrouter.ai/minimax/minimax-m2

mcowger · 2025-12-02T23:02:46Z

@mcowger which model are you working with?

Minimax M2 (note, I cannot replicate this on OpenRouter). I cannot replicate this via GLM4.6 on the same provider, so it appears to be an interaction between the inference and the model and continue.

mcowger · 2025-12-02T23:11:57Z

I captured traces of the differences in the output:

https://gist.github.com/mcowger/3aea3a2314d9f5540e7bbf68d9cafcd7

GLM outputs double escaped strings, while M2 does not.

That should be enough to replicate with?

RomneyDa · 2025-12-02T23:13:01Z

This seems like could be a valid issue for other models as well, and if the tool implementation is looking for a string arg specifically, like the create new file tool, this fix seems fine.

I guess you would still see issues with MCP tools when they expect string JSON and receive JSON object. The solution might be to detect "type": "string" in the tool definition and use getStringArg to replace at the time of calling the MCP tool. Do you use MCP tools at all? I could open a separate issue for that

RomneyDa · 2025-12-02T23:14:59Z

Got it, thanks for the traces. It's no clear why the model would escape differently between providers (as far as I understand this would only happen because of something on the provider side) but I could see this happening in other situations as well and this fix won't hurt.

mcowger · 2025-12-02T23:18:20Z

Agree its a provider side issue, and I've filed a bug with them.

I dont use MCPs much, but I agree it could impact them as well.

RomneyDa

This looks good for now, can address MCP on a separate issue if it comes up

sestinj · 2025-12-04T19:53:14Z

🎉 This PR is included in version 1.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

sestinj · 2025-12-04T22:11:23Z

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

mcowger added 2 commits December 2, 2025 20:08

Add tests to match.

a381002

mcowger requested a review from a team as a code owner December 2, 2025 20:16

mcowger requested review from sestinj and removed request for a team December 2, 2025 20:16

github-project-automation bot added this to Issues and PRs Dec 2, 2025

github-project-automation bot moved this to Todo in Issues and PRs Dec 2, 2025

dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 2, 2025

RomneyDa requested changes Dec 2, 2025

View reviewed changes

github-project-automation bot moved this from Todo to In Progress in Issues and PRs Dec 2, 2025

Address comments from @RomneyDa

e04c21f

cubic-dev-ai bot reviewed Dec 2, 2025

View reviewed changes

RomneyDa reviewed Dec 2, 2025

View reviewed changes

RomneyDa approved these changes Dec 3, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 3, 2025

RomneyDa merged commit c6fc60b into continuedev:main Dec 3, 2025
57 of 58 checks passed

github-project-automation bot moved this from In Progress to Done in Issues and PRs Dec 3, 2025

github-actions bot locked and limited conversation to collaborators Dec 3, 2025

sestinj added the released label Dec 4, 2025

fix: handle JSON contents of create_new_file #8973

fix: handle JSON contents of create_new_file #8973

Uh oh!

Conversation

mcowger commented Dec 2, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

AI Code Review

Checklist

Screen recording or screenshot

Tests

Summary by cubic

Uh oh!

continue bot commented Dec 2, 2025

Uh oh!

continue-development-app bot commented Dec 2, 2025

Uh oh!

continue-development-app bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RomneyDa left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

continue bot commented Dec 2, 2025

Uh oh!

mcowger commented Dec 2, 2025

Uh oh!

mcowger commented Dec 2, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

RomneyDa left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcowger commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RomneyDa commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcowger commented Dec 2, 2025

Uh oh!

mcowger commented Dec 2, 2025

Uh oh!

RomneyDa commented Dec 2, 2025

Uh oh!

RomneyDa commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcowger commented Dec 2, 2025

Uh oh!

RomneyDa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sestinj commented Dec 4, 2025

Uh oh!

sestinj commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mcowger commented Dec 2, 2025 •

edited by cubic-dev-ai bot

Loading

github-actions bot commented Dec 2, 2025 •

edited

Loading

RomneyDa left a comment •

edited

Loading

RomneyDa left a comment •

edited

Loading

mcowger commented Dec 2, 2025 •

edited

Loading

RomneyDa commented Dec 2, 2025 •

edited

Loading

RomneyDa commented Dec 2, 2025 •

edited

Loading